Android: Pad menu fragment when expanding to cutout area #11314
Merged
+119
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
reviewed
Dec 2, 2022
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/fragments/MenuFragment.java
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/fragments/MenuFragment.java
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/fragments/MenuFragment.java
Outdated
Show resolved
Hide resolved
t895
force-pushed
the
menu-cutout-padding
branch
2 times, most recently
from
67f0293
to
a1c101e
Compare
JosJuice
reviewed
Dec 2, 2022
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/fragments/MenuFragment.java
Outdated
Show resolved
Hide resolved
t895
force-pushed
the
menu-cutout-padding
branch
3 times, most recently
from
b2e0087
to
bcc5343
Compare
JosJuice
reviewed
Dec 3, 2022
t895
force-pushed
the
menu-cutout-padding
branch
from
bcc5343
to
3670fe5
Compare
JosJuice
reviewed
Dec 3, 2022
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/fragments/MenuFragment.java
Show resolved
Hide resolved
t895
force-pushed
the
menu-cutout-padding
branch
2 times, most recently
from
f9f0cad
to
cff8b1d
Compare
JosJuice
reviewed
Dec 4, 2022
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/fragments/MenuFragment.java
Outdated
Show resolved
Hide resolved
t895
force-pushed
the
menu-cutout-padding
branch
from
cff8b1d
to
2a0939a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Previously mentioned in #11313
Before when using the "Expand to Cutout Area" setting, camera notches/other device insets could get in the way of the ingame menu fragment. Now we apply padding based on inset and this accounts for RTL layouts.
Additionally, I've removed unused attributes from the xml and slightly tweaked the padding of the fragment itself to appear clearer.
Before (camera would appear in the way of text on the left) -
After -
