HW/Memmap: Refactor Memory to class, move to Core::System. #11320
+2,221
−1,360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiralCurtiss
force-pushed
the
globals-memory
branch
from
546183c
to
839db59
Compare
iwubcode
reviewed
Dec 3, 2022
| @@ -3,11 +3,14 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <array> | |||
There was a problem hiding this comment.
You could remove <array> and Common/MemArena.h includes from the cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This commit is gigantic and I'm sorry. A lot of code touches Memory it turns out. I can try to split this up into parts but I'm not sure how much that would help?