Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: New settings fragment animations #11327

Merged
merged 1 commit into from Dec 6, 2022
Merged

Android: New settings fragment animations #11327

merged 1 commit into from Dec 6, 2022
+112 −145

Conversation

t895
Copy link
Contributor

@t895 t895 commented Dec 5, 2022 •
edited

The old animations were pretty dated so these should help the UI feel a bit faster.

Before -
animation-demo-old

After -
animation-demo

@MayImilae
Copy link
Contributor

WAY better. LGTM.

@JosJuice
Copy link
Member

JosJuice commented Dec 6, 2022 •
edited

Please add RTL versions of the animations that use the X axis.

@t895
Copy link
Contributor Author

t895 commented Dec 6, 2022

(Pardon the flickering, my emulator is busted)

RTL Demo -
animation-demo-rtl

@JosJuice JosJuice merged commit 2a23aab into dolphin-emu:master Dec 6, 2022
11 checks passed
@t895 t895 deleted the settings-animation branch January 1, 2023 04:03
@t895 t895 mentioned this pull request Mar 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@t895 @MayImilae @JosJuice