Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: fix compile error #11341

Merged
merged 1 commit into from Dec 11, 2022

Conversation

mbc07
Copy link
Contributor

@mbc07 mbc07 commented Dec 11, 2022

I'm not sure how this passed through our automated checks but PR #11325 got merged with a semantic error that breaks the Android port. This PR fixes that and allows the Android port to be built again...

@t895
Copy link
Contributor

t895 commented Dec 11, 2022

That's really weird, but LGTM

@mbc07
Copy link
Contributor Author

mbc07 commented Dec 11, 2022

My best guess is that PR #11325 required a rebase to use SwitchSetting() after PR #11336 got merged (after all that PR got rid of CheckboxSetting()), but somehow the automated checks didn't run again and thus they didn't catch the compile error...

@Pokechu22 Pokechu22 merged commit cac5d0b into dolphin-emu:master Dec 11, 2022
8 of 11 checks passed
@mbc07 mbc07 deleted the BlackBackgrounds_buildfix branch December 11, 2022 06:30
@JosJuice
Copy link
Member

Yeah, the buildbots don't run again unless you push a new version of the PR or manually tell them to rebuild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants