Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MemoryViewWidget background colour #11349

Merged
merged 1 commit into from Dec 17, 2022

Conversation

noahpistilli
Copy link
Contributor

In commit 6f4f4e0 on line 552, the background of the memory viewer was filled to be white. In dark mode this would make it impossible to see the contents of the viewer.

Screenshot 2022-12-16 at 5 46 08 PM

@Pokechu22
Copy link
Contributor

This change results in the cell staying red if you right-click and select "toggle breakpoint" twice (or if you scroll when a breakpoint is on screen).

I think using cell->setBackground(Qt::transparent); would give the desired result without causing that problem, though?

@noahpistilli
Copy link
Contributor Author

Good catch, just tested and using that gives the desired result.

@AdmiralCurtiss AdmiralCurtiss merged commit 685e512 into dolphin-emu:master Dec 17, 2022
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants