New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Externals: Add Dear Implot #11356
Externals: Add Dear Implot #11356
Conversation
|
This should be using a submodule for the |
| @@ -168,6 +168,7 @@ PRIVATE | |||
| spng | |||
| xxhash | |||
| imgui | |||
| implot | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to add implot as a dependency should be done in the PR that is actually using them
is there a reason that ImGui is not done like this? I just wanted to keep it consistent with ImGui. |
@Sam-Belliveau - it is an older dependency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me. Thanks!
|
Looks good in general, but you might wanna clean up those commits (because many of them have no discernable meaning when looked at in isolation). To squash those commits into one before continuing; you can use the following commands (replace The first command makes sure you get the latest commits from |
Thank you I really could not remember how to do this |
95f2e06
to
5ca438d
Compare
This is a dependency for the branches I am working on. I am currently blocked on this.
I do not know if this builds on windows.