Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try for system libmgba first #11362

Merged
merged 1 commit into from Jan 17, 2023
Merged

Conversation

alucryd
Copy link
Contributor

@alucryd alucryd commented Dec 22, 2022

Patch made for the arch linux package, figured I would try to upstream it. Please let me know if that is something desirable, and if so whether it's in acceptable state or requires modifications.

@Pokechu22
Copy link
Contributor

Based on #9600 (comment) there were previously concerns about distros shipping libmbga but not libmgba-dev, and also about determinism with netplay/movies where the same version of dolphin should imply the same version of libmgba. I'm not sure how relevant these concerns (particularly the former) are nowadays though.

@delroth
Copy link
Member

delroth commented Jan 17, 2023

Based on #9600 (comment) there were previously concerns about distros shipping libmbga but not libmgba-dev

I don't think you'd have a pkg-config file if it's not libmgba-dev anyway? So it will fall back to Externals as it currently does.

determinism with netplay/movies where the same version of dolphin should imply the same version of libmgba

Sounds like we should fix this by including a libmgba version string in the netplay handshake then?

@delroth delroth merged commit 4fc6488 into dolphin-emu:master Jan 17, 2023
11 checks passed
@v1993
Copy link
Contributor

v1993 commented Feb 14, 2023

Note: this PR had an issue with include directory detection that's fixed by #11566.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants