DolphinQt: add ability to lock / freeze values in the watches window #11365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
… be executed each frame
iwubcode
force-pushed
the
cheat_manager_freeze_value
branch
from
9fd8cff
to
90b0854
Compare
iwubcode
changed the title
… we're already on the cpu thread
iwubcode
force-pushed
the
cheat_manager_freeze_value
branch
from
90b0854
to
c62ed99
Compare
…add a memory location found in a cheat search to be added to the watch list
…e (used during locking)
iwubcode
force-pushed
the
cheat_manager_freeze_value
branch
from
c62ed99
to
31bf9d0
Compare
lioncash
reviewed
Dec 31, 2022
Source/Core/Core/PatchEngine.cpp
Outdated
| @@ -257,6 +262,15 @@ static void ApplyPatches(const std::vector<Patch>& patches) | |||
| } | |||
| } | |||
|
|
|||
| static void ApplyMemoryPatches(const std::vector<std::size_t>& memory_patch_indices) | |||
There was a problem hiding this comment.
I forget if we're completely over to C++20, but if we are, perhaps make this a std::span
Suggested change
| static void ApplyMemoryPatches(const std::vector<std::size_t>& memory_patch_indices) | |
| static void ApplyMemoryPatches(std::span<const std::size_t> memory_patch_indices) |
There was a problem hiding this comment.
Good point. I'll try and see if buildbot complains :)
There was a problem hiding this comment.
Did you want to change this, or...?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Was looking to find some values in memory for a new feature I'm working on. I wanted the ability to lock the value so I could see if I found the right one. To my dismay, the feature wasn't available. Looking at #9886 I see that the solution was broken and therefore removed.
I decided to take a stab at implementing it. I feel like there are too many interfaces for interacting with patches and would prefer to consolidate them but didn't want to do anything too heavy handed at the moment. So this PR adds a way for
PatchEngineto apply memory patches on each frame.This adds the ability to lock/freeze values to the watches window. It also allows multi-selection for easy deletion and lock/unlocking of values. Finally, it adds an 'Add to Watch' option to the cheat search, so you don't have to go through the memory view