Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Allow users to interact with switches in settings #11369

Merged
merged 1 commit into from Dec 24, 2022
Merged

Android: Allow users to interact with switches in settings #11369

merged 1 commit into from Dec 24, 2022

Conversation

t895
Copy link
Contributor

@t895 t895 commented Dec 24, 2022

Before you couldn't grab and flick a switch. This is now consistent with the rest of the UX.

Before -
switch-old

After -
switch-new

@JosJuice
Copy link
Member

With this change, it's possible to change the state of a switch for which isEditable returns false. (The change doesn't propagate to the backend, but to the user it looks like the setting has changed value, which is confusing.)

@MayImilae
Copy link
Contributor

This is a great change from a UX perspective!

@t895
Copy link
Contributor Author

t895 commented Dec 24, 2022

I disabled the switch when not editable and the toast will still appear if you tap the body of the setting.

Screenshot_20221224-025545.png

@JosJuice JosJuice merged commit b3bc9c4 into dolphin-emu:master Dec 24, 2022
11 checks passed
@t895 t895 deleted the switch-fix branch January 1, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@t895 @JosJuice @MayImilae