Android: Make more meticulous use of DeleteLocalRef #11376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we're in a function that isn't just going to immediately return to Java, leaking local references can lead to problems eventually.
JosJuice
force-pushed
the
android-delete-local-ref
branch
from
a5154ca
to
9fbf6b6
Compare
JosJuice
force-pushed
the
android-delete-local-ref
branch
from
9fbf6b6
to
b3a368a
Compare
lioncash
approved these changes
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If we're in a function that isn't just going to immediately return to Java, leaking local references can lead to problems eventually.