Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Common: Fix Speed Counter Sample Size #11379

Conversation

Sam-Belliveau
Copy link
Contributor

A typo in the original commit made the speed counter sample the last 6 seconds (because of some smoothing it ends up being more like 10 seconds)

This commit reverts it back to its original 0.5s

@Sam-Belliveau Sam-Belliveau marked this pull request as ready for review December 26, 2022 21:48
@Pokechu22
Copy link
Contributor

This definitely improves things, but I feel like it would make more sense to use the value given by "performance sample window" instead of hardcoding a specific value for the speed counter, so that all 3 counters are in sync. If that would be difficult to implement, this is good enough, though.

@Sam-Belliveau
Copy link
Contributor Author

This definitely improves things, but I feel like it would make more sense to use the value given by "performance sample window" instead of hardcoding a specific value for the speed counter, so that all 3 counters are in sync. If that would be difficult to implement, this is good enough, though.

it would be easy to implement, but the emulation speed counter is meant to be used by internal aspects of dolphin (like ideally the sound in the future) and was made so that the performance sample window wouldnt affect things like sound.

Copy link
Contributor

@Pokechu22 Pokechu22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, that's probably fine then. Perhaps it could be changed so that the performance window affects the UI version only and not the one used internally, but I don't think that needs to be done now.

@AdmiralCurtiss AdmiralCurtiss merged commit 529909f into dolphin-emu:master Dec 27, 2022
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants