VideoCommon: De-globalize VertexShaderManager class. #11388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
reviewed
Dec 28, 2022
| alignas(16) static std::array<float, 16> g_fProjectionMatrix; | ||
|
|
||
| // track changes | ||
| static std::array<bool, 2> bTexMatricesChanged; |
There was a problem hiding this comment.
Can remove <array> include from cpp since it is now in the header
There was a problem hiding this comment.
Since VertexShaderManager.cpp also uses an std::array independent of its class (see eg. the pos_matrix_ptrs in SetConstants()) that would end up relying on an indirect include from the header, so if for whatever reason you factored out the #include <array> from VertexShaderManager.h you would suddenly end up with a missing definition for std::array in the .cpp file. Obviously this is a personal preference to some degree, but I like to (try to, at least) ensure that a .cpp file doesn't rely on indirect includes like that.
iwubcode
approved these changes
Dec 28, 2022
lioncash
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.