Android: Move FPS-related settings to a submenu #11393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back when this was just the FPS setting, having it in the top level of the graphics settings was reasonable. But now it's seven settings. Let's add a new submenu for them.
|
This is exactly what I think we should do eventually on desktop, it's just a little harder over there with placement and what not. But yea, this is a great idea. |
|
The FPS options were really starting to take up a lot of room. Great idea, LGTM. |
lioncash
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Back when this was just the FPS setting, having it in the top level of the graphics settings was reasonable. But now it's seven settings. Let's add a new submenu for them.