Externals: Exclude libcurl.rc from the build #11394
Conversation
yes that's correct (it's used in the target binary image, which could also be .exe or something). |
Externals/curl/curl.vcxproj
Outdated
| @@ -358,7 +358,9 @@ | |||
| <ClInclude Include="lib\x509asn1.h" /> | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
| <ResourceCompile Include="lib\libcurl.rc" /> | |||
| <ResourceCompile Include="lib\libcurl.rc"> | |||
There was a problem hiding this comment.
could also just delete the ItemGroup
There was a problem hiding this comment.
Indeed, that should also work. There are a few other files that are also marked as excluded, though, which were added in 3b3551f (by you). Any reason why that was done, instead of deleting the relevant lines?
There was a problem hiding this comment.
Since those are 'normal' compiled items files, I thought it might help in the future to make updating the External easier, so you could tell which files were purposefully excluded vs. new files after updating. In retrospect I don't think it's really that helpful. I agree I haven't been uniform in that over time.
There was a problem hiding this comment.
I'll just delete the item group instead, then.
For some reason, when this is included, the linking step creates a temporary file in %TEMP% with a random name; the file is deleted afterwards and a new random name is used on a later build. Because this file doesn't exist on a later build, curl gets re-linked each time, and then all of the projects that depend on curl also get re-linked. This adds around 10 seconds to the build time even for small changes. To make things worse, I don't think libcurl.rc does anything useful since we statically link curl; I believe the metadata contained in it only applies when building a dll. (It does seem to be included in curl.lib, but gets discarded when linking Dolphin.exe.) See Build\x64\Release\curl\curl.tlog\Lib-link-cvtres.write.1.tlog for the log that shows this path (the file is also mentioned after setting Tools -> Options... -> Projects and Solutions -> Build and Run -> MSBuild project build output verbosity to diagnostic, but not in a useful way).
Pokechu22
force-pushed
the
exclude-libcurl.rc
branch
from
27fb346
to
e344eb7
Compare
For some reason, when this is included, the linking step creates a temporary file in %TEMP% with a random name; the file is deleted afterwards and a new random name is used on a later build. Because this file doesn't exist on a later build, curl gets re-linked each time, and then all of the projects that depend on curl also get re-linked. This adds around 10 seconds to the build time even for small changes.
To make things worse, I don't think libcurl.rc does anything useful since we statically link curl; I believe the metadata contained in it only applies when building a dll. (It does seem to be included in curl.lib, but gets discarded when linking Dolphin.exe.)
See Build\x64\Release\curl\curl.tlog\Lib-link-cvtres.write.1.tlog for the log that shows this path (the file is also mentioned after setting Tools -> Options... -> Projects and Solutions -> Build and Run -> MSBuild project build output verbosity to diagnostic, but not in a useful way).