Debugger: Add string comparison to conditional breakpoints #11398
+42
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeekyCt
changed the title
lioncash
reviewed
Jan 1, 2023
AdmiralCurtiss
force-pushed
the
conditional-bp-streq
branch
from
812bb98
to
4e6e510
Compare
|
Rebased this to fix a conflict that snuck in due to #11554. Seems to work. I'm getting some spurious pauses with conditional breakpoints but that doesn't seem to be this PRs fault. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Adds a basic
streqfunction to conditional breakpoints for comparison of strings in RAM and/or string constants. It takes two parameters, either of which can be an address or a string constant.Examples of valid calls:
streq(r3, "abc")streq(0x8000000, r3)streq("abc", 0x80000000)streq("abc", "abc")