Android: Add slider for Performance Sample Window #11413
Merged
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! |
JosJuice
reviewed
Jan 8, 2023
.../src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragmentPresenter.java
Outdated
Show resolved
Hide resolved
JosJuice
reviewed
Jan 8, 2023
...ndroid/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsAdapter.java
Outdated
Show resolved
Hide resolved
t895
force-pushed
the
sample-window-slider
branch
3 times, most recently
from
13af978
to
2cb819b
Compare
Credit to JosJuice for the slider formula
t895
force-pushed
the
sample-window-slider
branch
from
2cb819b
to
937e089
Compare
lioncash
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Additionally I changed the slider step size based on how large the total range is. This makes large ranges like the one used for this sample window much easier to control. Since we haven't had to control values greater than 100 before, I've also increased the size of the value text field.
Audio Slider -
Sample Window Slider -
