Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdl: update to latest sdl2 #11418

Merged
merged 2 commits into from Jan 31, 2023
Merged

sdl: update to latest sdl2 #11418

merged 2 commits into from Jan 31, 2023

Conversation

shuffle2
Copy link
Contributor

@shuffle2 shuffle2 commented Jan 8, 2023

(i'm just updating this arbitrarily as I happen to notice new commits to the SDL2 branch which touch input related code)

maybe related issues (current open SDL bugs):
https://bugs.dolphin-emu.org/issues/13045
https://bugs.dolphin-emu.org/issues/13117
https://bugs.dolphin-emu.org/issues/13125

@iwubcode
Copy link
Contributor

Have we found any documentation that says SDL2 branch is appropriate? Why is it chosen over main or one of the released tags?

@shuffle2
Copy link
Contributor Author

why not main: main is now active dev of sdl3 and is seeing a lot of api-breaking code churn. sdl2 branch still gets some fixes backported / fixes specifically for version 2.
why not release/tag: sdl is notorious for having a lot of bugs, and we generally just stay at HEAD to get the bugfixes without waiting for releases (dolphin has been doing this with main, previously)

@phire phire merged commit ed3ad94 into dolphin-emu:master Jan 31, 2023
14 checks passed
@dvessel
Copy link
Contributor

dvessel commented Feb 2, 2023

Just a note in case anyone else runs into this. Launching through the command line with —batch will cause a EXC_BAD_ACCESS (SIGSEGV) error when quitting. This is on MacOS Ventura. I had to go back to the brew install of sdl2 to prevent it.

It also changes the controller name on the DualSense controller so it has to be updated in your controller/hotkeys settings.

@shuffle2
Copy link
Contributor Author

shuffle2 commented Feb 2, 2023

Please report SDL bugs to SDL :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants