Android: Copy baseline profile during release builds #11420
Merged
+10
−3,899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pokechu22
reviewed
Jan 10, 2023
t895
force-pushed
the
copy-profile
branch
2 times, most recently
from
a0d7755
to
b1e05c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I'm moving generation of the baseline profile to the buildbot and once that's complete, I created a copy task that will take the profile from the managed device and put it into the correct location before the build starts. This only occurs during a release build since creating the profile can be a long extra build step (launching a headless emulated device and waiting for a simulation to run) when you might just want to make a quick debug build.
This also removes the pre-generated baseline profile since that will quickly become out-of-date and offer less and less performance improvements as new libraries are added. I suppose we could keep it around and update it every once in a while, but I don't see it as worth doing.