Android: Ignore workaround view height if 0 #11428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't the height 1 in practice for the cheats activity? |
Not quite, turns out samsung will still fire the window inset events in their fullscreen modes. This tells the workaround view to have a height of 0 and then the constraint layout interprets this as covering the whole screen. This makes sure that we ignore that report. Edit- confirmed working by AGES in discord |
|
Right, you're checking if the inset's height is 0, not if the view's height is 0. Makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts a change made in #11410 in hopes of fixing fullscreen modes on Samsung devices when using the cheats activity.