Reduce usage of ppcState global. #11429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiralCurtiss
force-pushed
the
globals-ppc
branch
from
30b23aa
to
f781f43
Compare
|
Why the intermediate PowerPCManager class? Couldn't we just have system.GetPPCState() returning a PowerPCState instance instead? |
|
Yes, I suppose so, I was just following the way I have refactored the other global state files so far where at the end everything of a given file ended up in a single class. But given the way |
AdmiralCurtiss
force-pushed
the
globals-ppc
branch
from
f781f43
to
efa58e6
Compare
|
Like this, I assume? |
AdmiralCurtiss
force-pushed
the
globals-ppc
branch
from
efa58e6
to
104ff94
Compare
AdmiralCurtiss
force-pushed
the
globals-ppc
branch
from
104ff94
to
346f57c
Compare
AdmiralCurtiss
force-pushed
the
globals-ppc
branch
from
346f57c
to
505a61f
Compare
AdmiralCurtiss
force-pushed
the
globals-ppc
branch
from
505a61f
to
be2d394
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I stopped before I got to the JIT because that was looking like it needed a bit more refactoring and this was already getting gigantic...
Right now
system.GetPPCState()is just a reference to theppcStateglobal, but I'm aiming to completely eliminate that and to have it actually just have aPowerPCStateinstance inSysteminstead.Every commit should compile as-is, which may be useful for bisecting in case I made an error somewhere.