VertexLoader: Fix loading tangent/binormal caches with NormalIndex3 #11432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pokechu22
force-pushed
the
generic-vertex-loader-test-error
branch
2 times, most recently
from
8e55758
to
0de9145
Compare
Pokechu22
changed the title
Pokechu22
force-pushed
the
generic-vertex-loader-test-error
branch
2 times, most recently
from
9ccd6c1
to
fd408ad
Compare
|
not very related but, dolphin's version of gtest hasn't been updated in a while, any idea if updating it would improve anything? |
Pokechu22
force-pushed
the
generic-vertex-loader-test-error
branch
from
fd408ad
to
2e3d105
Compare
This prevents a failed assertion from hanging on the MSVC buildbots.
Logs don't show up in unit tests, and since this is debugging functionality (though not enabled for tests by default) it's better to do it this way.
This is the behavior in the x64 and ARM64 vertex loaders. I don't know if it makes sense (the whole skipped vertex system seems jank, but several games behave incorrectly without it).
Pokechu22
force-pushed
the
generic-vertex-loader-test-error
branch
from
2e3d105
to
3910bdd
Compare
|
I don't think updating it would help anything for this PR, but I'll look into doing a separate PR as it probably would be easy to make it a submodule. This PR now passes everything when built with COMPARE_VERTEXLOADERS (2e3d105), and also without it. So it should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes the generic nightly builder (see #10808 (comment)).
I didn't catch this because I did my testing using
COMPARE_VERTEXLOADERS, which did not check the various caches. The issue was the software vertexloader not writing to the tangent/binormal caches, but this was obscured since the JIT vertexloader did load to them.Additionally,
COMPARE_VERTEXLOADERSwouldn't be visible in unit tests since logging wasn't enabled. I changed that to asserts, and also changed the test system to register a custom message alert handler (as otherwise the assertion popup would appear on the msvc buildbot and never close, forcing the 20-minute timeout, and on other platforms a failed dolphin assertion wouldn't be treated as a test failure).