Jit64: Fix the offsetAddedToAddress correction #11441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, it doesn't matter. The instruction that comes after the LEA after backpatching will treat the register as 32-bit anyway. (And the LEA we're trying to undo also treated the register as 32-bit, so what this PR is doing isn't any better than what the code was doing before...) I'm planning to get rid of the offsetAddedToAddress correction in an upcoming PR, so no need to make this kind of refinement to it. |
The LEA that the signal handler is trying to undo the effects of is a 32-bit instruction, and the value in the register prior to the LEA is also 32-bit, so the signal handler should use a 32-bit write. (Actually, in the end this doesn't really matter, because the first instruction that reads this value after backpatching is also a 32-bit instruction...)
JosJuice
force-pushed
the
jit64-lea-fixup
branch
from
f100518
to
78c53bf
Compare
|
I don't think I will get rid of offsetAddedToAddress after all. I've re-opened this PR with an updated version of the commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x86 address displacements are treated as signed, not unsigned.