Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MenuBar: Add action which opens the user folder #11450

Merged
merged 1 commit into from Jan 16, 2023
Merged

MenuBar: Add action which opens the user folder #11450

merged 1 commit into from Jan 16, 2023

Conversation

OatmealDome
Copy link
Member

Here's how it looks:

image

@OatmealDome OatmealDome force-pushed the open-user-dir-qt branch 2 times, most recently from 178a239 to 31e4f98 Compare January 16, 2023 08:53
@shuffle2
Copy link
Contributor

uh...can't this just be done with Qt somehow? https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/DolphinQt/GameList/GameList.cpp#L696

@delroth
Copy link
Member

delroth commented Jan 16, 2023

+1, seems like a job for QDesktopServices::openUrl

@OatmealDome
Copy link
Member Author

🤦‍♂️ I didn't know that existed, thanks.

delroth
delroth approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@delroth delroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, haven't tested. If someone confirms this works as expected feel free to merge.

@MayImilae
Copy link
Contributor

I'll give it a test and a screenshot if the Windows builder can build. :/

@OatmealDome OatmealDome marked this pull request as ready for review January 16, 2023 09:13
@MayImilae
Copy link
Contributor

MayImilae commented Jan 16, 2023 •
edited

Tested on macOS 12. Works fine! Also quite handy actually as going to the library is a bit of a pain there.

Tested on Windows 11 and it also works fine. Here's a screenshot!

dolphindir

The worst part of this PR is that it messes with my muscle memory for exiting Dolphin. Fortunately I'll be fixing that problem shortly~

@delroth delroth merged commit 2d783f8 into dolphin-emu:master Jan 16, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delroth delroth delroth approved these changes

@MayImilae MayImilae MayImilae approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@OatmealDome @shuffle2 @delroth @MayImilae