Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuBar: Tweak string for open user folder option #11451

Merged
merged 1 commit into from Jan 16, 2023

Conversation

OatmealDome
Copy link
Member

Last minute change: "Open User Folder" -> "Open Global User Directory", since the latter is what we've used in the past.

image

@delroth delroth merged commit aacd66b into dolphin-emu:master Jan 16, 2023
11 checks passed
@AdmiralCurtiss
Copy link
Contributor

Wait, is that right? I thought 'Global User Directory' was specifically the one that gets used if no other one is specified (ie, the one that was in Documents before and is now in AppData), but if you had eg. a portable.txt or used the -u command line option it would cease to be Global and become a Local User Directory. That's what the wiki page implies, anyway.

@JosJuice
Copy link
Member

I agree with @AdmiralCurtiss. Calling it global is incorrect if it's not actually stored in the global location (or now, one of the two global locations).

@MayImilae
Copy link
Contributor

MayImilae commented Jan 16, 2023

Global to Dolphin. In the past Dolphin builds used local user directories only beside the EXE, but with the change around 4.0 all Dolphin builds would share one "global" user directory. That's where it comes from. It's what we have called it since the feature was made.

https://dolphin-emu.org/docs/guides/controlling-global-user-directory/
https://dolphin-emu.org/blog/2013/09/22/dolphin-40-release-announcement/

@JosJuice
Copy link
Member

What I mean is, if you use portable.txt then the folder you're using is not global. The portable.txt section of the guide you're linking to even specifically says "Disable the Global User Directory" and "To make a build use a local user directory".

@MayImilae
Copy link
Contributor

OH, it's super late here. Yea that's a whoops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants