Revert "MenuBar: Tweak string for open user folder option" #11453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nicer to have the menu item change depending on whether the user directory was local or global, rather than reverting. But we can still do that later after a revert, so eh. |
|
I missed the initial discussion, so maybe there's an obvious reason but I don't really see a point to distinguishing between "global" and "local". It makes it harder for support (user could say "there's no 'Open Global User Folder') and just in general...why should the user care? It's the folder where they want to make changes for their given instance, does it matter where it is? Anyway, that is just my initial reaction, I'll roll with whatever :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This reverts PR #11451.
The user folder can be either global or local. If it is local, we shouldn't call it global.
See also PR #10216.