Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implot: Don't compile implot_demo.cpp #11454

Merged
merged 1 commit into from Jan 17, 2023

Conversation

OatmealDome
Copy link
Member

@OatmealDome OatmealDome commented Jan 16, 2023

implot_demo.cpp depends on functions from imgui_demo.cpp, which we do not have. Appears to cause linking errors only on my fork, but I figured I would upstream this anyway.

@Pokechu22
Copy link
Contributor

It might be better for us to include imgui_demo.cpp, as it is useful as an example (and shouldn't have much costs otherwise). But removing this also seems like a valid approach.

@shuffle2
Copy link
Contributor

Please remove it from compilation (ie this PR as-is) if it's never used/not needed. I think it takes a long time to compile (have just noticed console output stalling there, but a lot of stuff is compiling in parallel and I haven't profiled it, so not sure).

@delroth delroth merged commit 283f217 into dolphin-emu:master Jan 17, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants