Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Add about dialog #11455

Merged
merged 1 commit into from Jan 24, 2023
Merged

Android: Add about dialog #11455

merged 1 commit into from Jan 24, 2023

Conversation

t895
Copy link
Contributor

@t895 t895 commented Jan 16, 2023

Demo -

signal-2023-01-16-143919_002.mp4

I also made sure that the dialog is forcefully expanded and fully navigable on devices with no touchscreen.

@MayImilae
Copy link
Contributor

MayImilae commented Jan 17, 2023

Landscape is definitely not great. How does it look on a television and or tablet?

@t895
Copy link
Contributor Author

t895 commented Jan 17, 2023

Landscape is definitely not great. How does it look on a television and or tablet?

About the same, I could add a variant to better use wide displays though.

@MayImilae
Copy link
Contributor

Switching to a layout that is optimized for landscape to better handle that orientation would be very nice.

@mbc07
Copy link
Contributor

mbc07 commented Jan 18, 2023

The "check for updates" link seems hardcoded to Dolphin's website, however, Play Store builds has a different signing key from the builds from the website and thus they can't be installed on top of each other without uninstalling the previous version first.

Can you detect whether the currently running build comes from Play Store and change the "check for updates" link accordingly? (e.g. Play Store version points to the Play Store app listing, other builds points to Dolphin's website)

@t895
Copy link
Contributor Author

t895 commented Jan 18, 2023

Can you detect whether the currently running build comes from Play Store and change the "check for updates" link accordingly? (e.g. Play Store version points to the Play Store app listing, other builds points to Dolphin's website)

I really like the idea but it's not really feasible unless we made a build variant for the play store and the website. I could change it to something like "Get the latest builds here:"? I'm open to suggestions.

@t895
Copy link
Contributor Author

t895 commented Jan 18, 2023

Here's the current revisions of the dialog

Small -
image

Wide -
image

@mbc07
Copy link
Contributor

mbc07 commented Jan 18, 2023

The portrait layout LGTM, but the landscape layout still seems a bit weird... I think it's the left column that gives this impression, as it essentially has only the logo. Have you considered moving the "Dolphin" title and the version string (5.0-xxxxx) to the left column, below the logo, and adding a small separator between the two columns (similar to the landscape user data activity)? This might be enough to make it prettier...

@t895
Copy link
Contributor Author

t895 commented Jan 19, 2023

Have you considered moving the "Dolphin" title and the version string (5.0-xxxxx) to the left column, below the logo, and adding a small separator between the two columns (similar to the landscape user data activity)? This might be enough to make it prettier...

Even though I'm not a fan of it I put together a quick draft of what that would look like. I still don't enjoy this look. It de-emphasizes the logo and the divider doesn't feel right to me.
image

I'm perfectly happy with the existing landscape layout.

@mbc07
Copy link
Contributor

mbc07 commented Jan 19, 2023

Yep, that doesn't look prettier. At least on paper it made sense, but seeing the end result, it indeed looks worse. Please disregard my landscape suggestion...

@t895
Copy link
Contributor Author

t895 commented Jan 22, 2023

Does anyone have problems with the design or code at this point?

Copy link
Contributor

@MayImilae MayImilae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design LGTM~

@delroth delroth merged commit 014d057 into dolphin-emu:master Jan 24, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants