New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Add about dialog #11455
Android: Add about dialog #11455
Conversation
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/fragments/AboutDialogFragment.kt
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/ui/main/MainPresenter.java
Outdated
Show resolved
Hide resolved
|
Landscape is definitely not great. How does it look on a television and or tablet? |
About the same, I could add a variant to better use wide displays though. |
|
Switching to a layout that is optimized for landscape to better handle that orientation would be very nice. |
|
The "check for updates" link seems hardcoded to Dolphin's website, however, Play Store builds has a different signing key from the builds from the website and thus they can't be installed on top of each other without uninstalling the previous version first. Can you detect whether the currently running build comes from Play Store and change the "check for updates" link accordingly? (e.g. Play Store version points to the Play Store app listing, other builds points to Dolphin's website) |
I really like the idea but it's not really feasible unless we made a build variant for the play store and the website. I could change it to something like "Get the latest builds here:"? I'm open to suggestions. |
|
The portrait layout LGTM, but the landscape layout still seems a bit weird... I think it's the left column that gives this impression, as it essentially has only the logo. Have you considered moving the "Dolphin" title and the version string (5.0-xxxxx) to the left column, below the logo, and adding a small separator between the two columns (similar to the landscape user data activity)? This might be enough to make it prettier... |
|
Yep, that doesn't look prettier. At least on paper it made sense, but seeing the end result, it indeed looks worse. Please disregard my landscape suggestion... |
|
Does anyone have problems with the design or code at this point? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Design LGTM~



Demo -
signal-2023-01-16-143919_002.mp4
I also made sure that the dialog is forcefully expanded and fully navigable on devices with no touchscreen.