windows: prefer os version from registry #11458
Merged
+102
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuffle2
force-pushed
the
winuver
branch
2 times, most recently
from
1e53ca9
to
65e3dae
Compare
this value is not modified by compatibility mode drop reporting service pack numbers. no longer used
|
@delroth poke on this one? thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
this value is not modified by compatibility mode
drop reporting service pack numbers. no longer used
AFAIK ignoring the fact that dolphin or updater is running under compatibility mode should raise no problems for our use case.