Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Reveal several hidden settings #11460

Merged
merged 9 commits into from Jan 29, 2023
Merged

Android: Reveal several hidden settings #11460

merged 9 commits into from Jan 29, 2023

Conversation

t895
Copy link
Contributor

@t895 t895 commented Jan 18, 2023

These were all oddly not available in the Android app. Now they are.

  • IPL Skip Main Menu
  • Accurate CPU Cache
  • Frame Dump Compression Level
  • Force Linear/Nearest filtering options
  • Emulated Memory Size Override
  • Custom RTC
  • A few headers that should've been there

I'm also really happy with the work I put into the RTC selector so here's a demo.
dateTime

@t895 t895 force-pushed the reveal-settings branch 2 times, most recently from 1a2ddd0 to 36f4e1b Compare January 18, 2023 06:50
@JMC47
Copy link
Contributor

JMC47 commented Jan 19, 2023

This looks amazing, and it further brings Dolphin Android closer to Desktop in terms of features.

@JosJuice
Copy link
Member

IPL Skip Main Menu

The user must not be allowed to disable this setting when they don't actually have an IPL file in the required directory, otherwise you will introduce a UX problem that we used to have on desktop where games won't boot and the user won't figure out why unless they can remember that they disabled this setting.

Accurate CPU Cache

Sound good. This simply hadn't been added to the Android GUI because it was added to Dolphin very recently.

Frame Dump Compression Level

This is kind of useless without the ability to actually start frame dumping. Or are you adding this for the sake of controlling the compression level of PNG screenshots?

Force Linear/Nearest filtering options

Same as with Accurate CPU Cache.

Emulated Memory Size Override

Please limit the available values to the same values as on PC. The in-between values aren't useful.

Custom RTC

Looks good at a quick glance.

A few headers that should've been there

No real opinion on this one. Seems fine, I suppose.

@t895
Copy link
Contributor Author

t895 commented Jan 19, 2023

The user must not be allowed to disable this setting when they don't actually have an IPL file in the required directory

Oh shoot, I'll look into preventing this.

This is kind of useless without the ability to actually start frame dumping

Just for the sake of controlling the compression level of screenshots for now.

Please limit the available values to the same values as on PC

They are already limited.

@JosJuice
Copy link
Member

They are already limited.

Oh, whoops, somehow I thought the PC version didn't allow you to use steps of 1 MiB in the GUI, but it actually does. Okay, let's leave it as it is then.

@t895
Android: Add safeguards around skip ipl setting
860f561 
A user shouldn't be able to disable "skip ipl" when they don't have a bios file. This finds the ipl file and tells the setting when toggling is allowed. Additionally, if the user previously disabled the option and then deletes their ipl file, they will be allowed to enable it but toggling will be disabled afterwards.
@t895
Copy link
Contributor Author

t895 commented Jan 27, 2023

Is anything holding this back?

@JMC47
Copy link
Contributor

JMC47 commented Jan 28, 2023

Tested some of the settings revealed here and they work.

@delroth delroth merged commit 05b7792 into dolphin-emu:master Jan 29, 2023
14 checks passed
@t895 t895 mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosJuice JosJuice JosJuice left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@t895 @JMC47 @JosJuice @delroth