Don't Write OSD Messages to the Titlebar #11471
Merged
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out all OSD messages, every single one, are written to the titlebar. We've just never seen them because the FPS is in the title bar and it replaces it in a fraction of a second. This was only visible when saving savestates because it halts emulation for a moment while writing. This is dumb, let's not do that anymore.
|
Gitblame traces it to #905. It was added to put OSD messages into the status bar. Dolphin Qt doesn't have a status bar. Looks like this is just an oversight from the WX to Qt transition. |
Simonx22
approved these changes
Jan 22, 2023
BhaaLseN
approved these changes
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
It turns out all OSD messages, every single one, are written to the titlebar. We've just never seen them because the FPS/VPS etc display is in the title bar and it replaces it in a fraction of a second. This was only visible when saving savestates because it halts emulation for a moment while writing.
This is dumb, let's not do that anymore. Fixes issue 12604.
Before -
After -
There is still dox potential in the saving states from the OSD but that's for a separate PR.