Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Filepath from State Save/Load OSD Messages #11485

Merged

Conversation

MayImilae
Copy link
Contributor

@MayImilae MayImilae commented Jan 24, 2023

Though less important compared to #11470, save states also show the full path in the OSD message and could potentially dox a streamer who is playing a game in Dolphin. This is a simple fix - it removes the path from the OSD message so only the name of the state file is revealed.

Also makes the state messages less intrusive.

Before -
savestate2-before
loadstate2-before

After -
savestate2-after
loadstate2-after

@MayImilae MayImilae force-pushed the remove-filepath-from-states-messaging branch 2 times, most recently from 7c2f5cf to a4230fe Compare January 24, 2023 11:05
@MayImilae MayImilae changed the title Removed filepath from State Save/Load OSD messages Remove Filepath from State Save/Load OSD Messages Jan 24, 2023
Though less important compared to dolphin-emu#11470, save states also show the full path in the OSD message and could potentially dox a streamer who is playing in Dolphin. This is a simple fix - it removes the path from the message and only displays the file name.
@MayImilae MayImilae force-pushed the remove-filepath-from-states-messaging branch from a4230fe to ed121ee Compare January 24, 2023 15:56
@delroth delroth merged commit c6a7465 into dolphin-emu:master Jan 26, 2023
14 checks passed
@MayImilae MayImilae deleted the remove-filepath-from-states-messaging branch March 27, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants