Improve the data in the first data block of the skylanders figures #11492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dolphin-emu-bot rebuild |
delroth
approved these changes
Jan 25, 2023
|
@mandar1jn we probably don't want to include the unknown - if it's something like a copyright or a company specific identifier? |
mandar1jn
changed the title
|
@dolphin-emu-bot rebuild |
|
@JMC47 it’s impossible that this is caused by my code right? |
|
These should clear up if you rebase your PR onto latest master. |
|
How do I do that? |
|
Something along the lines of |
* Added NUID * Added BCC * Added ATQA * Added SAK
|
Okay. Should be good now |
delroth
reviewed
Jan 31, 2023
| @@ -521,6 +522,7 @@ const std::map<const std::pair<const u16, const u16>, const char*> list_skylande | |||
| SkylanderPortalWindow::SkylanderPortalWindow(QWidget* parent) : QWidget(parent) | |||
| { | |||
| setWindowTitle(tr("Skylanders Manager")); | |||
| setWindowIcon(Resources::GetAppIcon()); | |||
There was a problem hiding this comment.
In the future please be careful not to include random unrelated changes like this in your commits...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The real Skylanders cards are Mifare 1K classic cards with a 4-byte NUID so this mimics the real cards. The calculation used before could cause duplicate NUIDs very easily.
Added an icon to the Skylanders portal window