Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameINI: Heavy Iron updates #11493

Merged
merged 1 commit into from Feb 12, 2023
Merged

Conversation

icup321
Copy link
Contributor

@icup321 icup321 commented Jan 26, 2023

This PR provides a small batch of GameINI updates:

  • The Incredibles: Removes EFBToTextureEnable = False because there is no noticeable difference with this option enabled/disabled after testing several times, seems like it might have been added by mistake?

  • 2-in-1 compilations: Updated game settings to match the single-game releases and fixed an incorrectly named game entry (GU3.ini).

@JMC47
Copy link
Contributor

JMC47 commented Jan 26, 2023

Is it worth the performance loss to remove the purple stripes in those games? You have to remember that GPU syncs are incredibly slow on Android devices.

@JosJuice
Copy link
Member

JosJuice commented Jan 26, 2023

Historically we haven't considered purple bars in FMVs to be important enough to take the performance loss in game INIs.

@icup321
Copy link
Contributor Author

icup321 commented Jan 26, 2023

Is it worth the performance loss to remove the purple stripes in those games? You have to remember that GPU syncs are incredibly slow on Android devices.

Yes, for the SpongeBob Movie game at least seems to use the XFBs as temporary storage sometimes for rendering functions which has caused certain mods (such as a WIP multi-player mod) to break as it reads from the XFB without really caring what state the game is in:
https://user-images.githubusercontent.com/28464642/214970376-cd06db88-5ac6-4260-ad6b-65fc93c0a9a2.mp4

Usually this works fine for other Heavy Iron games but it fails for movie game for the reasons I described.

@JMC47
Copy link
Contributor

JMC47 commented Jan 26, 2023

Explanation LGTM.

@JosJuice
Copy link
Member

I don't think mods should be used as justification to forcibly set a setting for the base game.

@JMC47
Copy link
Contributor

JMC47 commented Jan 30, 2023

I'd be more confident merging this without the XFB2RAM change for Spongebob Movie, and we can move that to a separate PR for further discussion maybe?

@icup321
Copy link
Contributor Author

icup321 commented Jan 30, 2023

Alright, I've removed the XFB2RAM settings. After talking with the mod creator, we couldn't really come to a conclusion as to how exactly the game uses XFBs, and whether or not a fix is actually necessary for the base game anyway. I think it will probably have to be looked into by someone else with deeper knowledge on the game's code.

@JMC47
Copy link
Contributor

JMC47 commented Jan 31, 2023

It's something that can be discussed at a later date anyway. The other changes are pretty obviously good. I made a TON of INI changes at once and I made a few mistakes it seems.

Edit: Can you modify your pull request message to remove the point about enabling XFB2RAM now that it's not in the PR anymore. Just to reduce confusion if someone stumbles upon this later.

@icup321
Copy link
Contributor Author

icup321 commented Feb 8, 2023

Reminder that I removed the XFB2RAM point on the first post, so this should be ready for merging if there are no other suggestions.

@AdmiralCurtiss AdmiralCurtiss merged commit 9737345 into dolphin-emu:master Feb 12, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants