Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PPCAnalyst: Actually check if instructions want CR #11503

Merged
merged 3 commits into from Feb 13, 2023
Merged

PPCAnalyst: Actually check if instructions want CR #11503

merged 3 commits into from Feb 13, 2023

Conversation

JosJuice
Copy link
Member

@JosJuice JosJuice commented Jan 28, 2023 •
edited

Split out from PR #9857 for ease of review. Doesn't do much on it's own, it's mostly preparation and code cleanup.

@JosJuice
PPCTables: Add new instruction flags for CR
3b57fb1
@JosJuice
PPCAnalyst: Use bitsets for CR analysis
9d2c4aa 
Currently we're only performing CR analysis for CR0 and CR1, but I
would like to do it for all CRs. Bitsets are appropriate for this.
@JosJuice
PPCAnalyst: Actually check if instructions want CR
e273390
AdmiralCurtiss
AdmiralCurtiss approved these changes Feb 12, 2023
View reviewed changes
Copy link
Contributor

@AdmiralCurtiss AdmiralCurtiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested, and I didn't verify whether you got all the instructions that read CR, but looks fine to me.

@AdmiralCurtiss AdmiralCurtiss merged commit 3458c58 into dolphin-emu:master Feb 13, 2023
14 checks passed
@JosJuice JosJuice deleted the ppcanalyst-read-cr branch February 14, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdmiralCurtiss AdmiralCurtiss AdmiralCurtiss approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@JosJuice @AdmiralCurtiss