VideoCommon: Avoid creating pipelines with no render targets #11511
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some backends don't like it when you do that
This only actually fails on specific Metal drivers, this way doing it will actually fail the CI and we'll notice
phire
reviewed
Jan 30, 2023
| @@ -1068,6 +1068,13 @@ bool Renderer::InitializeImGui() | |||
|
|
|||
| bool Renderer::RecompileImGuiPipeline() | |||
| { | |||
| if (m_backbuffer_format == AbstractTextureFormat::Undefined) | |||
There was a problem hiding this comment.
This would have saved me several hours of debugging a few days ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes nogui on Intel HD 4000 macs