Android: Create ScaledIntSetting class #11513
Merged
+140
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t895
requested changes
Jan 30, 2023
...roid/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/ScaledIntSetting.kt
Outdated
Show resolved
Hide resolved
|
The annotations are a great addition. |
JosJuice
force-pushed
the
android-scaled-int-setting
branch
from
c543d4a
to
2760ccf
Compare
t895
approved these changes
Jan 30, 2023
JosJuice
force-pushed
the
android-scaled-int-setting
branch
from
2760ccf
to
17203ce
Compare
A little refactoring to cut down on the size of the very big SettingsFragmentPresenter class. I ended up adding a bunch of @nonnull annotations in various settings classes so I could make the parameters `Settings` instead of `Settings?` in the new Kotlin code.
JosJuice
force-pushed
the
android-scaled-int-setting
branch
from
17203ce
to
2e8ad9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
A little refactoring to cut down on the size of the very big SettingsFragmentPresenter class.
I ended up adding a bunch of @nonnull annotations in various settings classes so I could make the parameters
Settingsinstead ofSettings?in the new Kotlin code.