Android: Set each slider step size manually #11517
Merged
+28
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This reverts part of #11413 where we tried to calculate the appropriate slider step size based on the given range. This turned out to be inappropriate because there can be settings like Emulated CPU Clock Speed % that go up to 400%. Users would like to have the ability to change that by a step size of 1. Seeing as we could get caught in a cycle of constantly adjusting section of a slider that can be stepped by 1, changing the step for each slider individually seemed like a better solution.