Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set VI Skip Activation to Half The Audio Buffer #11533

Merged
merged 2 commits into from Feb 3, 2023

Conversation

Sam-Belliveau
Copy link
Contributor

It's kinda complicated to explain why I would want to do this but here it goes.

It does not actually matter where the VI Skip Activation is, all that matters is that:

  1. It's not too close to 0 [on time] because that causes unnecessary sleeping
  2. It's not too close to -100ms, because that causes slow down
  3. It's shorter than the audio buffer (prevents skips when going from >100% to <100%)

The current VI Deadline is exactly the length of the audio buffer which CAN cause stutters when VI Skip begins to activate. This should get rid of that stutter.

@Sam-Belliveau Sam-Belliveau marked this pull request as ready for review February 3, 2023 03:18
@JMC47 JMC47 merged commit aece99f into dolphin-emu:master Feb 3, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants