Rename "Speed up Disc Transfer Rate" to "Emulate Disc Speed" #11538
Conversation
t895
force-pushed
the
disc-speed-stuff
branch
from
21b700c
to
b5c21e0
Compare
|
If the intention is to keep users from using the faster disc reading speed senselessly, I doubt this can prevent it. Users looking to make things faster will do dumb things sometimes. However, this new approach is more thoughtfully worded and switching the direction should at least stop the "see 'speed up', immediately click" action. So I think this is an improvement. LGTM. |
|
Changing the name in the GUI makes sense to me, but I'm unsure if we really should break existing configs by also renaming the INI name of the setting. |
|
Yeah I'm with Jos, you should leave the backend setting alone and just have the GUI setting behave inverted. |
t895
force-pushed
the
disc-speed-stuff
branch
from
b5c21e0
to
888a9fd
Compare
|
I've inverted the option in the UI but kept the key so we don't break configs. I haven't touched the Qt code before so please let me know if this is a bad way of doing this. |
There was a problem hiding this comment.
The INI setting and reading code is really ugly tbqh, but making it nicer (transition the dialog to GraphicsBool and similar, maybe?) is really out of scope for this PR.
Likewise, does Android not have a wrapper for a GUI element that is inverted compared to the INI setting?
But yeah other than that seems fine.
|
JosJuice informed me that yes, we have |
t895
force-pushed
the
disc-speed-stuff
branch
from
888a9fd
to
0ed64b0
Compare
Don't know how I missed that. Fixed. |
Following a suggestion from @mbc07, this renames the "Speed up Disc Transfer Rate" option to "Emulate Disc Speed" and inverts the setting. Since we have no guarantee as to whether or not the improved version of instant reads will ever be created, this allows us to keep the current implementation in a way that will hopefully reduce encourage reckless user behavior.
Additionally, this PR exposes the option in the Android GUI.