Update GraphicMods #11542
Update GraphicMods #11542
Conversation
| "meta": | ||
| { | ||
| "title": "Bloom and HUD Texture Definitions", | ||
| "author": "iwubcode" |
There was a problem hiding this comment.
I think that's very nice of you to mention me but you can take the credit for this one ;)
| "features": | ||
| [ | ||
| { | ||
| "group": "DOF", |
There was a problem hiding this comment.
We should move this to a "Native Resolution DOF" all target like we have for bloom. See https://github.com/dolphin-emu/dolphin/blob/master/Data/Sys/Load/GraphicMods/All%20Games%20Native%20Resolution%20Bloom/all.txt and https://github.com/dolphin-emu/dolphin/blob/master/Data/Sys/Load/GraphicMods/All%20Games%20Native%20Resolution%20Bloom/metadata.json
There was a problem hiding this comment.
Do you feel comfortable making that change?
There was a problem hiding this comment.
I'd also suggest adding a "DOF Removal" like we do for bloom: https://github.com/dolphin-emu/dolphin/blob/master/Data/Sys/Load/GraphicMods/All%20Games%20Bloom%20Removal/metadata.json .
| { | ||
| "meta": | ||
| { | ||
| "title": "Bloom and HUD Texture Definitions", |
There was a problem hiding this comment.
"Bloom and DOF Texture Definitions"
linckandrea
force-pushed
the
master
branch
2 times, most recently
from
374a96e
to
42b65bb
Compare
|
Thank you for the tips how it is now? also updated TLS HUD(i wasn't able to identify the remain texure in the upper left) |
| "texture_filename": "efb1_n11_320x240_1" | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
Missing a ] after this to close the "groups" section
|
@linckandrea - tested this out. Overall is very good but I am questioning if Pandora's Tower has DOF. Last Story does and it is very obvious there. But what we call DOF in Pandora's Tower just seems like more bloom? My suggestion would be to merge Pandora's Tower's DOF efb copies into the bloom group. My apologies, I probably should have caught it from your screenshots. |
|
Doesn't DOF bloom out of focus things? because if i open the tower travel menu the background is bloomed (check the grass in the bottom left)
|
There was a problem hiding this comment.
Forgot to approve this. My original concern was that there's some overlap between the two terms, likely due to how the system can't easily single out a particular effect. However, there's not much that can be done about that right now. So this LGTM. Great work!
Adds global "Native Resolution DOF" and "DOF Removal"
Adds bloom and DOF definitions for Pandora's Tower
The Last Story: Update HUD mod and move DOF efb target to the proper group
Normal
Native res Bloom and DOF
Skip Bloom and DOF
TLS HUD