VideoCommon: add constant value for maximum number of pixel samplers #11550
+62
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
force-pushed
the
set_common_samplers_count
branch
2 times, most recently
from
60f70d6
to
0fd3c16
Compare
iwubcode
force-pushed
the
set_common_samplers_count
branch
from
0fd3c16
to
af313f8
Compare
|
Are there other good candidate constant that can make the new file more useful? It looks very silly otherwise. |
|
@Rumi-Larry - maybe in the future I'll move some of the other constants over. This is for another feature I'm working on. So no plans at this time, keeping it simple. |
|
Code wise this looks fine, I cannot tell whether the constants are appropriate in every location they're used though. |
phire
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.