Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename VI Skip to VBI Skip #11553

Merged
merged 1 commit into from Feb 12, 2023

Conversation

MayImilae
Copy link
Contributor

The fact that VI Skip used "VI" made it very difficult to explain on the blog. There are SO many things called VI already! This small changes clarifies what VI Skip is to resolve that issue, and makes it not use the "VI" anymore so it no longer conflicts with the other VI things.

I only changed the Qt and Android GUIs, not the INI or internal options. Since there was already some consensus in favour of this on discord and samb gave it a +1, the goal is to get this merged fast so we can get it into the report and publish. And not break anything.

I'll need someone else to test on Android, but here is the change on Linux.

vbiskip1

vbiskip2

VI Skip was very hard to explain on the blog, so this small changes
clarifies what VI Skip is to resolve that issue.
@JMC47
Copy link
Contributor

JMC47 commented Feb 12, 2023

We can't do this, a bunch of experimental stuff was pushed after the Progress Report was set. Plus translations would need to catch up again.

@MayImilae
Copy link
Contributor Author

MayImilae commented Feb 12, 2023

IMO it's ok if translation is a little behind. It's not exactly a big change here!

As for the little experimental stuff, I was not intending to update the beta for this. We can change the name and have a note at the bottom explaining the discrepancy for one single beta build. It's fine~

@JMC47
Copy link
Contributor

JMC47 commented Feb 12, 2023

I'm good with merging this, I just don't want to move the progress report build. The naming makes it a little more clear.

@t895
Copy link
Contributor

t895 commented Feb 12, 2023

LGTM

@JMC47 JMC47 merged commit efed037 into dolphin-emu:master Feb 12, 2023
14 checks passed
@MayImilae MayImilae deleted the rename-viskip-to-vbiskip branch February 12, 2023 06:31
@JosJuice
Copy link
Member

IMO it's ok if translation is a little behind. It's not exactly a big change here!

To be clear, when you change a string, the translated versions of that string don't keep using the outdated translations, they revert entirely to English. But since we tagged an older build as the beta, that's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants