Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address WIL todos in UICommon.cpp #11555

Merged
merged 1 commit into from Feb 20, 2023
Merged

Address WIL todos in UICommon.cpp #11555

merged 1 commit into from Feb 20, 2023

Conversation

CookiePLMonster
Copy link
Contributor

This PR migrates SetUserDirectory to use Windows Implementation Libraries, as specified by now implemented TODOs.

AdmiralCurtiss
AdmiralCurtiss approved these changes Feb 12, 2023
View reviewed changes
Copy link
Contributor

@AdmiralCurtiss AdmiralCurtiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, untested.

@lioncash lioncash merged commit 6f21ce7 into dolphin-emu:master Feb 20, 2023
@CookiePLMonster CookiePLMonster deleted the wil-todos branch February 20, 2023 15:17
@Medard22 Medard22 mentioned this pull request Feb 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lioncash lioncash lioncash approved these changes

@AdmiralCurtiss AdmiralCurtiss AdmiralCurtiss approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@CookiePLMonster @lioncash @AdmiralCurtiss