DiscIO: Add support for CleanRip-style split ISOs. #11557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiralCurtiss
force-pushed
the
split-file-reader
branch
from
cb047a2
to
640cffa
Compare
iwubcode
reviewed
Feb 13, 2023
BhaaLseN
reviewed
Feb 13, 2023
|
I get the logic behind this, but should we really be enabling this? Games wont be able to verify properly, and overall there's literally zero benefit to having the files split, so wouldn't it make more sense to tackle this at the source? |
|
Or, alternatively, this could maybe be retrofitted into something that lets the user know that their dumps are split and offers to combine them, perhaps with this still remaining as a fallback if necessary? |
|
Oh but they do verify properly, they even convert properly! And there's no disadvantage to having them split either (in fact, there is one advantage: they work on a FAT32 file system, which is the whole reason CleanRip splits them in the first place). |
|
Never mind then. Well done! |
iwubcode
approved these changes
Feb 13, 2023
sepalani
reviewed
Feb 15, 2023
AdmiralCurtiss
force-pushed
the
split-file-reader
branch
from
640cffa
to
1925f96
Compare
AdmiralCurtiss
force-pushed
the
split-file-reader
branch
from
1925f96
to
655cc7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I occasionally see people struggling with the combine-after-ripping step, so I figured this would be useful to have, and it's pretty simple to implement.