Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HookableEvent: Switch to construct on first use #11560

Merged

Conversation

phire
Copy link
Member

@phire phire commented Feb 13, 2023

A registration might happen during static initialization, which opens us up to issues with ordering of static initialization.

A registration might happen during static initialization, which opens
us up to issues with ordering of static initialization.
Copy link
Contributor

@AdmiralCurtiss AdmiralCurtiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup makes sense.

@AdmiralCurtiss AdmiralCurtiss merged commit 5f929d0 into dolphin-emu:master Feb 14, 2023
@phire phire deleted the EventHook_construct_on_first_use branch February 14, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants