Common/FileUtil: Revert behavior of CreateFullPath().

[AdmiralCurtiss]

This was accidentally changed in 7e6436d.

Compare the old code:

dolphin/Source/Core/Common/FileUtil.cpp

Lines 252 to 287 in 9d139ea

	bool CreateFullPath(const std::string& fullPath)
	{
	int panicCounter = 100;
	DEBUG_LOG_FMT(COMMON, "CreateFullPath: path {}", fullPath);
	if (Exists(fullPath))
	{
	DEBUG_LOG_FMT(COMMON, "CreateFullPath: path exists {}", fullPath);
	return true;
	}
	size_t position = 0;
	while (true)
	{
	// Find next sub path
	position = fullPath.find(DIR_SEP_CHR, position);
	// we're done, yay!
	if (position == fullPath.npos)
	return true;
	// Include the '/' so the first call is CreateDir("/") rather than CreateDir("")
	std::string const subPath(fullPath.substr(0, position + 1));
	if (!IsDirectory(subPath))
	File::CreateDir(subPath);
	// A safety check
	panicCounter--;
	if (panicCounter <= 0)
	{
	ERROR_LOG_FMT(COMMON, "CreateFullPath: directory structure is too deep");
	return false;
	}
	position++;
	}
	}

to the new code:

dolphin/Source/Core/Common/FileUtil.cpp

Lines 213 to 226 in 8f91cb6

	bool CreateFullPath(const std::string& fullPath)
	{
	DEBUG_LOG_FMT(COMMON, "{}: path {}", __func__, fullPath);
	std::error_code error;
	auto native_path = StringToPath(fullPath);
	bool success = fs::create_directories(native_path, error);
	// If the path was not created, check if it was a pre-existing directory
	if (!success && fs::is_directory(native_path))
	success = true;
	if (!success)
	ERROR_LOG_FMT(COMMON, "{}: failed on {}: {}", __func__, fullPath, error.message());
	return success;
	}

Specifically the part where the old code returns as soon as it doesn't find any more directory separators.

[shuffle2]

sorry, what was the problem here? don't get it

[jordan-woyak]

sorry, what was the problem here? don't get it

CreateFullPath("dir1/dir2/file") was inadvertently also creating a "file" directory.

[sepalani]

What about renaming CreateFullPath to CreateParentDirs or similar? AFAICT, the behaviour seems similar to mkdir -p which does just that. CreateFullPath is a confusing name which seems to imply creating the "fullpath" including directories and file.

EDIT: After a second thought maybe CreateDirsFromPath is a better name as I don't think it's strictly identical to mkdir -p neither.

[AdmiralCurtiss]

Yeah, probably a good idea to rename that to be more clear.

[shuffle2]

sorry, what was the problem here? don't get it

CreateFullPath("dir1/dir2/file") was inadvertently also creating a "file" directory.

ok, yea....I'd say dolphin should probably be changed to not expect that, but (I guess) it works as-is so can be punted.

[player112972]

I'm having a problem updating the emulator. Version 5.0-18661

[AdmiralCurtiss]

This is very much the wrong place for support. Go to the discord or the forums or something.

(but you probably just have to manually update, I'm guessing the issue addressed in this PR broke the updater for those affected versions)