Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jit64: Use 5 byte jump in mtmsr for the CP interrupt check. #11575

Merged
merged 1 commit into from Feb 16, 2023
Merged

Jit64: Use 5 byte jump in mtmsr for the CP interrupt check. #11575

merged 1 commit into from Feb 16, 2023

Conversation

AdmiralCurtiss
Copy link
Contributor

WriteExternalExceptionExit() can write more than the maximum offset of the small jump.

Fixes this issue in Resident Evil Archives (the REmake port for the Wii):
https://cdn.discordapp.com/attachments/521711075721478145/1075605414311374929/image.png

@AdmiralCurtiss
Jit64: Use 5 byte jump in mtmsr for the CP interrupt check.
0c48324 
WriteExternalExceptionExit() can write more than the maximum offset of the small jump.
JosJuice
JosJuice approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@JosJuice JosJuice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cool to only use 5 bytes when the exception exit ends up so large that it's required, but that is just not something our JIT is designed for. Ah well.

@degasus degasus merged commit 1903116 into dolphin-emu:master Feb 16, 2023
14 checks passed
@AdmiralCurtiss AdmiralCurtiss deleted the mtmsr-5byte-jmp branch February 16, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosJuice JosJuice JosJuice approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@AdmiralCurtiss @JosJuice @degasus