Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update sdl #11581

Merged
merged 1 commit into from Feb 18, 2023
Merged

update sdl #11581

merged 1 commit into from Feb 18, 2023

Conversation

shuffle2
Copy link
Contributor

@AdmiralCurtiss
Copy link
Contributor

sure

@AdmiralCurtiss AdmiralCurtiss merged commit 45b55f7 into dolphin-emu:master Feb 18, 2023
@TellowKrinkle
Copy link
Contributor

Is there a reason this commit was chosen for the update? It's missing the fix for https://bugs.dolphin-emu.org/issues/13155 (libsdl-org/SDL@2c69957)

@shuffle2
Copy link
Contributor Author

no reason, i just did git pull and assumed it updated to latest without double checking

@shuffle2
Copy link
Contributor Author

shuffle2 commented Feb 19, 2023 •
edited

actually, the commit includes the commit you referenced. idk why github's ui doesn't seem to show it in the diff view, tho
https://github.com/libsdl-org/SDL/commits/f741adc86c8f5e7fc5c1863cf0d5e08b899d6209

the github ui does show it actually : libsdl-org/SDL@038ccd7...f741adc#diff-bebf8223264356e4c6c3999d5638324d16ea47ff5cdcb1324fb80c39a0337069
just not in a super-friendly way i guess

@TellowKrinkle
Copy link
Contributor

Ahh, I assumed it listed the most recent on top (like it does in other commit list views), saw the top being "last month", and was like "???"

Yay for them swapping the commit display order with a view that looks otherwise identical

@tvoracek
Copy link

tvoracek commented Feb 20, 2023 •
edited

Latest experimental/canary crashes during update because of outdated C++ redistributable. Why this is not handled in installer?

@TellowKrinkle
Copy link
Contributor

TellowKrinkle commented Feb 21, 2023 •
edited

Was that caused by an SDL update? If not, you should post that on https://bugs.dolphin-emu.org

@shuffle2
Copy link
Contributor Author

It sounds like dupe of https://bugs.dolphin-emu.org/issues/13173

@Medard22 Medard22 mentioned this pull request Feb 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@shuffle2 @AdmiralCurtiss @TellowKrinkle @tvoracek