Common/FileUtil: Rename Copy() to CopyRegularFile(). #11595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
as for naming, maybe CopyRegularFile (based on file_type https://en.cppreference.com/w/cpp/filesystem/file_type) |
AdmiralCurtiss
force-pushed
the
rename-file-copy
branch
from
bd2f0e8
to
9c6f24a
Compare
|
Yes, that's definitely a better name, let's go with that. |
This is to clarify that it can only copy files, not folders.
AdmiralCurtiss
force-pushed
the
rename-file-copy
branch
from
9c6f24a
to
e52aa52
Compare
AdmiralCurtiss
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
It can only copy files, not directories, so make that clear in the name. (also so I can free up the name for a generic copy-any function)
I originally wanted to name this just
CopyFile()but then realized that Windows.h has a#definefor that, so that'd be probably more trouble than it's worth. If you have a better name suggestion feel free.