Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: Restore Bluetooth adapter missing message in Controller Settings #11601

Conversation

Dentomologist
Copy link
Contributor

@Dentomologist Dentomologist commented Feb 24, 2023

In 5.0 an error message was displayed in the Controller Settings if a Bluetooth adapter wasn't found. That message was lost in the transition from wx to Qt, so this PR restores it.

I kept the 5.0 wording but removed the GroupBox since the current Controller layout doesn't have nested GroupBoxes.

Appearance:

current_no_adaptercurrent_normal

5.0 Appearance:
5-0_no_adapter5-0_normal

@jordan-woyak
Copy link
Member

Since 5.0 I believe we've changed all UI instances of "Wiimote" to the proper name of "Wii Remote". Please update the message to say "Wii Remote".

@Dentomologist Dentomologist force-pushed the bluetooth_adapter_missing_message branch from 4cf029b to d18735e Compare February 24, 2023 22:32
@AdmiralCurtiss
Copy link
Contributor

Can this even show up? WiimoteScannerHidapi always returns true for querying if ready.

bool WiimoteScannerHidapi::IsReady() const
{
return true;
}

@Dentomologist
Copy link
Contributor Author

On Windows at least, yes. I'm not sure if Linux includes Hidapi by default, but if it doesn't (or you disable it for some reason) then it should show up there too.

@AdmiralCurtiss AdmiralCurtiss merged commit 8c7997d into dolphin-emu:master Mar 9, 2023
14 checks passed
@Dentomologist Dentomologist deleted the bluetooth_adapter_missing_message branch March 10, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants